Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2223714: [release-4.13] Fix issue with empty s3 profile config #182

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #181

/assign vbnrh

This commit fixes issue where s3 profile config is not updated in the Ramen config map.
This is due to a race condition existing between MCO and Ramen where Ramen starts after MCO during upgrade at which point s3profile is updated and  Ramen replaces this with newly created default config.

This fix will ensure that any changes to Ramen configmap is watched and triggers reconcile for all secrets in the current namespace which should ensure that s3profile is properly updated regardless of the upgrade sequence.

Signed-off-by: vbadrina <[email protected]>
@vbnrh
Copy link
Member

vbnrh commented Oct 30, 2023

/retitle Bug 2217549: [release-4.13] Fix issue with empty s3 profile config

@openshift-ci openshift-ci bot changed the title [release-4.13] Bug 2217549: Fix issue with empty s3 profile config Bug 2217549: [release-4.13] Fix issue with empty s3 profile config Oct 30, 2023
@vbnrh
Copy link
Member

vbnrh commented Oct 30, 2023

/retest

@agarwal-mudit
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

@agarwal-mudit: This pull request references Bugzilla bug 2217549, which is invalid:

  • expected the bug to target the "ODF 4.13.5" release, but it targets "ODF 4.14.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vbnrh
Copy link
Member

vbnrh commented Oct 31, 2023

/retitle Bug 2223714: [release-4.13] Fix issue with empty s3 profile config

@openshift-ci openshift-ci bot changed the title Bug 2217549: [release-4.13] Fix issue with empty s3 profile config Bug 2223714: [release-4.13] Fix issue with empty s3 profile config Oct 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2223714, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.5) matches configured target release for branch (ODF 4.13.5)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keemano

In response to this:

Bug 2223714: [release-4.13] Fix issue with empty s3 profile config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keemano.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2223714, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.5) matches configured target release for branch (ODF 4.13.5)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keemano

In response to this:

Bug 2223714: [release-4.13] Fix issue with empty s3 profile config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vbnrh
Copy link
Member

vbnrh commented Oct 31, 2023

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

@vbnrh: This pull request references Bugzilla bug 2223714, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.5) matches configured target release for branch (ODF 4.13.5)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keemano

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keemano.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@vbnrh: This pull request references Bugzilla bug 2223714, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.5) matches configured target release for branch (ODF 4.13.5)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keemano

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 9a6272f into red-hat-storage:release-4.13 Oct 31, 2023
8 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2223714 has been moved to the MODIFIED state.

In response to this:

Bug 2223714: [release-4.13] Fix issue with empty s3 profile config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants